SearchKit - Add generic controller for ApiBatch action #24758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This allows extensions to define batch actions without the need for any javascript code
|
Woohoo - it works - putting up PR to add this to import search display |
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Nov 2, 2022
Port of civicrm/civicrm-core#24758 (which will be in stable releases from 5.56 - but we will be on 5.54.x until 2023. Bug: T295412 Change-Id: I369b720c5ba6080c0a0f6dc8e275e55ba4dbcc5a
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Nov 7, 2022
Normally each month the release goes out & then regression fixes go into a patch release - this grabs the ones merged to 5.54 since we put 5.54-rc out https://github.com/civicrm/civicrm-core/blob/5.55/release-notes/5.54.1.md https://github.com/civicrm/civicrm-core/blob/5.54/release-notes/5.54.2.md This should help avoid us hitting these regressions.... I re-applied our temporary patches - ie Email-processor-from civicrm/civicrm-core#24667 Port from upstream civicrm/civicrm-core#24758 Hack smarty-debug to OFF until the end of Big English Change-Id: I7d8124bd090af9c80bbcb1f486c5e1358e81aa39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This allows extensions to define simple batch actions without the need for any javascript code. They just need to specify an api action to perform on the selected entities, and some user-facing text to show on confirm/success/failure.
Documentation for this PR at https://lab.civicrm.org/documentation/docs/dev/-/merge_requests/1037
Before
Angular template and controller needed for all api-based tasks
After
Simple tasks without any configuration options can be declared in php, with no need for Angular code.