dev/core#3879 Fix failure to accept soft credit contact id #24858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@andyburnsco did you try this too? |
eileenmcnaughton
force-pushed
the
import_soft
branch
from
1336983
to
5c7c9e6
Compare
|
I just rebased as the other is merged |
|
@eileenmcnaughton I've tested this on 5.54.0 and it's working 👍 |
|
@seamuslee001 @colemanw can you merge per above? Thanks @andyburnsco |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#3879 Fix failure to accept soft credit contact id
https://lab.civicrm.org/dev/core/-/issues/3879
Before
After
fixed, tested
Technical Details
The contact id field wasn't previously tested so a previous array structure change was missed
Comments
Includes #24838 in order to get past that failure