Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import regression, fix loading of saved mapping with soft-credit email mapped #24871

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Nov 1, 2022

Overview

Import regression, fix loading of saved mapping with soft-credit email mapped

Before

Per #24838 (comment) - the soft credit email field is not loading from a saved mapping

After

it loads again

Technical Details

The js in the Quickform hierselect can't cope with the dots in the field name - so we are using substiution with '__' - but this spot was missed

Comments

@Detsieber

@civibot
Copy link

civibot bot commented Nov 1, 2022

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

@colemanw @seamuslee001 this has been tested y @Detsieber who commented over at #24838 (comment)

@seamuslee001 seamuslee001 merged commit c8ac10c into civicrm:5.55 Nov 1, 2022
@seamuslee001 seamuslee001 deleted the import_save_dots branch November 1, 2022 21:03
@eileenmcnaughton eileenmcnaughton mentioned this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants