[NFC] Minor cleanup in test #24921
Merged
[NFC] Minor cleanup in test #24921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Nov 8, 2022
| // Unique(ish) identifier for our controller/use-case. | ||
| 'controller' => 'civicrm_tokentest', | ||
| 'controller' => 'civicrm_token_test', |
There was a problem hiding this comment.
Avoid using non-English spelt words where possible so spelling checkers work
eileenmcnaughton
commented
Nov 8, 2022
| @@ -74,7 +76,6 @@ public function testTokenProcessor(): void { | |||
|
|
|||
| $this->assertNotEmpty($tokenProc->getRows()); | |||
| foreach ($tokenProc->getRows() as $tokenRow) { | |||
| /** @var \Civi\Token\TokenRow $tokenRow */ | |||
There was a problem hiding this comment.
not needed anymore as it is correctly declared in getRows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[NFC] Minor cleanup in test
Before
IDE warnings
After
poof
Technical Details
Comments