REF: Consistent variables names in formRule for CRM/Event/Form/Register #25045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -226,7 +226,7 @@ public function buildQuickForm() { | |||
| } | |||
|
|
|||
| $this->_amount[$k]['label'] = preg_replace('//', '', $v['amount_level']) . ' - ' . $append; | |||
| $this->_part[$k]['info'] = CRM_Utils_Array::value('first_name', $v) . ' ' . CRM_Utils_Array::value('last_name', $v); | |||
| $this->_part[$k]['info'] = ($v['first_name'] ?? '') . ' ' . ($v['last_name'] ?? ''); | |||
There was a problem hiding this comment.
ah right $v - gotta love those descriptive variables
| @@ -662,7 +660,7 @@ public function postProcess() { | |||
| if (isset($line['tax_amount']) && isset($line['tax_rate'])) { | |||
| $totalTaxAmount = $line['tax_amount'] + $totalTaxAmount; | |||
| if (isset($dataArray[$line['tax_rate']])) { | |||
| $dataArray[$line['tax_rate']] = $dataArray[$line['tax_rate']] + CRM_Utils_Array::value('tax_amount', $line); | |||
| $dataArray[$line['tax_rate']] = $dataArray[$line['tax_rate']] + ($line['tax_amount'] ?? 0); | |||
There was a problem hiding this comment.
so this one is an actual change - although not in a bad way
| @@ -955,13 +953,7 @@ private function processContribution( | |||
| } | |||
|
|
|||
| if (Civi::settings()->get('deferred_revenue_enabled')) { | |||
| $eventStartDate = CRM_Utils_Array::value( | |||
There was a problem hiding this comment.
OK - I've clearly hit the glazes stage - had to stare at this for a bit to realise it is right
|
I got a bit glazed reading through all of those but I think I checked every line. Defiitely more consistent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow on from #25044 (merge after #25044)
Before
Variables in formRule not consistent with names in Event/Form/Register
After
Variables in formRule consistent with names in Event/Form/Register
Technical Details
Comments