Add search/display details to searchKitTasks hook - allows for eg. filtering actions by search display

[mattwire]

Overview

You can't currently identify the search display when adding/removing tasks in the searchKitTasks hook. This means you can only provide actions per entity / user and not by search display.
Example:
In the AccountSync extension we have a display for errors which is showing AccountContact entities and provides a set of actions to handle those errors. But I want another display which shows all AccountContact entries that are NOT matched to CiviCRM contacts and offer actions to not sync / create / match. Each of these sets of actions make no sense on the other display.

Before

Can't identify search display

After

Can identify search display.

Technical Details

Pass extra params to the GetSearchTasks API call to include the name of the display.

I tried getting from ctrl.search and ctrl.display but ctrl.search seems to contain the display name and ctrl.display seems to be null?

Comments

@colemanw Does this seem like a sensible approach - do you know why ctrl.display/ctrl.search don't seem to contain what I expected?

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

The new apiBatch functionality really opens this whole topic up - because you can add custom actions to searches just by adding them via this hook. Not to suggest we shouldn't do this - but I think @colemanw has some paid work from @MegaphoneJon that would make the available actions configurable as part of the search & if that happens we wouldn't need to use code to make the available actions conditional.

[colemanw]

@eileenmcnaughton we can do both, and I think this PR will help in that direction.

[colemanw]

@mattwire this looks good apart from moving the $display variable to the other class. Mergeable as soon as that's fixed.

[mattwire]

I'm marking merge on pass per @colemanw comments