Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distmaker - Fix 'WordPress' entry in JSON report #25424

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

totten
Copy link
Member

@totten totten commented Jan 25, 2023

Overview

When publishing a release, distmaker produces is a JSON summary about the inputs and outputs. @christianwach found that the WordPress section was missing from the list of outputs.

Before

JSON output is missing something important:

    "rev" : "5.58.beta1-2e2455ba34bb2a02c2a886e107b0e20a",
    "tar" : {
       "Drupal" : "civicrm-5.58.beta1-drupal.tar.gz",
       "Joomla" : "civicrm-5.58.beta1-joomla.zip",
-      "WordPress" : "civicrm-5.58.beta1-wordpress.zip"
        ...

After

JSON output has something important:

    "rev" : "5.58.beta1-2e2455ba34bb2a02c2a886e107b0e20a",
    "tar" : {
       "Drupal" : "civicrm-5.58.beta1-drupal.tar.gz",
       "Joomla" : "civicrm-5.58.beta1-joomla.zip",
+      "WordPress" : "civicrm-5.58.beta1-wordpress.zip"
        ...

Technical Details

distmaker has silly variable names. Grep for WPPACK and WP5PACK to see which is more correct.

Comments

This is a little finnicky to test. I did do a local r-run with this patch and saw the fixed output , but... it is generally easier to test by merging and letting the autobuild run...

@civibot
Copy link

civibot bot commented Jan 25, 2023

(Standard links)

@civibot civibot bot added the 5.58 label Jan 25, 2023
@seamuslee001
Copy link
Contributor

Agree with it and merging so we can get those builds started sooner

@seamuslee001 seamuslee001 merged commit e707764 into civicrm:5.58 Jan 25, 2023
@totten totten deleted the 5.58-json-wp branch January 25, 2023 22:41
@christianwach
Copy link
Member

Thanks for fixing @totten

@totten
Copy link
Member Author

totten commented Jan 26, 2023

I downloaded the JSON file produced by a recent autobuild. Looks good:

   "tar" : {
      "Backdrop" : "civicrm-5.58.beta1-backdrop-unstable.tar.gz",
      "Drupal" : "civicrm-5.58.beta1-drupal.tar.gz",
      "Joomla" : "civicrm-5.58.beta1-joomla.zip",
      "L10n" : "civicrm-5.58.beta1-l10n.tar.gz",
      "WordPress" : "civicrm-5.58.beta1-wordpress.zip"
   },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants