dev/drupal#176 - allow symfony 6 #25499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
|
jenkins retest this please |
|
@demeritcowboy can you please rebase this and run |
demeritcowboy
force-pushed
the
symfony-composer-json
branch
from
f5a990c
to
6a6c115
Compare
|
Thanks yes good point. Have updated. |
|
Jenkins re test this please |
|
Woo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/drupal/-/issues/176
Before
Have to use a modified version of core to install on drupal 10
After
Can install on drupal 10 (along with #25054)
Technical Details
Note composer.lock is not changed here, so other cmses will still get what they are currently getting.
Comments
This and the other PR are the last remaining "hacks" needed.