dev/core#4112 Separate code to handle exporting legacy custom searches into the extension #25504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
cust_ex
branch
2 times, most recently
from
cafb33a
to
f1570fe
Compare
eileenmcnaughton
force-pushed
the
cust_ex
branch
from
f1570fe
to
fd3db2f
Compare
…s into the extension
eileenmcnaughton
force-pushed
the
cust_ex
branch
from
fd3db2f
to
2f53e9b
Compare
|
Good to move that code out of core. Giving |
colemanw
added
the
merge ready
|
@colemanw might be an ok time in the cycle to get this merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#4112 Separate code to handle exporting legacy custom searches into the extension
Before
Main
Exportclass does a call to a custom function for legacy custom searches (which callsCiviExitand quietly never returns https://github.com/civicrm/civicrm-core/compare/master...eileenmcnaughton:civicrm-core:cust_ex?expand=1#diff-5daa4963e0d6e7e84b8cd46c8ea1968cc88e2cb58ef3fe9abb701fb1dad62417L71After
legacy custom search export function moved to the extension & the Core_Controller directs the code to the use that function
Technical Details
Part of separating the legacy custom searches such that we can start to allow them to be disabled - https://lab.civicrm.org/dev/core/-/issues/4112
Comments