Smarty notice fix on trackingFields #25614
Conversation
|
(Standard links)
|
| @@ -7,7 +7,7 @@ | |||
| | and copyright information, see https://civicrm.org/licensing | | |||
| +--------------------------------------------------------------------+ | |||
| *} | |||
| {if $trackingFields and ! empty($trackingFields)} | |||
| {if array_key_exists('trackingFields', $form) and !empty($trackingFields)} | |||
There was a problem hiding this comment.
Does this make sense?
Also I can't find where trackingFields is ever defined?
There was a problem hiding this comment.
It was an old 'good idea' by Lobo - I was tempted to just pull them out & see if anyone noticed ...
There was a problem hiding this comment.
I didn't find any universe refs & apparently Wikimedia was the original 'client'
There was a problem hiding this comment.
The case for removing them from message templates seems very strong....
There was a problem hiding this comment.
I had to implement this, this week. I didn't know about $trackingFields, but I did pass values via the URL.
$trackingFields hides the fields from the form and receipt. My client was OK with the fields being visible and they use custom receipts. Otherwise, if I knew about this feature, I'd have used it.
I once proposed custom fields of type "hidden", which would solve this and more.
Thinking ahead - FormBuilder can populate fields from the URL without displaying them. Though I doubt anyone's figured out receipts when FB can process payments...
There was a problem hiding this comment.
@MegaphoneJon I guess that suggests that maybe someone else might use them if they are useful.
There was a problem hiding this comment.
Also - wouldn't it be a case of adding is_hidden to the field - which then starts to ask if we should use visibility better ....
|
I'm gonna close this for now - it's not quite clear if this is right or not at the momen |
@MegaphoneJon how about something like this? #27235 |
Overview
Fixes the top one of these