Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old deprecated class aliases #26025

Merged
merged 1 commit into from Apr 10, 2023

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Apr 7, 2023

Overview

Deletes old unused class aliases that were renamed years ago.

@civibot
Copy link

civibot bot commented Apr 7, 2023

(Standard links)

@civibot civibot bot added the master label Apr 7, 2023
@yashodha
Copy link
Contributor

@colemanw merging this PR. Thanks!

@yashodha yashodha merged commit 4ec78c8 into civicrm:master Apr 10, 2023
3 checks passed
@colemanw colemanw deleted the removeDeprecatedClasses branch April 10, 2023 18:29
@christianwach
Copy link
Member

@colemanw @yashodha It would have been good to have some warning about this. I've had to update a number of plugins that called CRM_Dedupe_BAO_RuleGroup::getByType() to use API4 instead. If people update to CiviCRM 5.62.x without updating their plugins first, their sites will throw a fatal error and become non-functional.

When aliasing classes, please please overload methods and implement something like _deprecated_function to write something to the logs so that developers are aware of the impending removal of classes and methods.

I'll opened a ticket on Lab since this looks like a regression to me - and there's only a couple of weeks for everyone to get prepared.

@christianwach
Copy link
Member

For reference, this is the PR that created the wrapper classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants