dev/core#4227 Fix import to not blank birth_date etc on update #26172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
562_import
branch
from
16c4808
to
ba0bf99
Compare
eileenmcnaughton
commented
May 8, 2023
| if (in_array($key, ['nick_name', 'job_title', 'middle_name', 'birth_date', 'gender_id', 'current_employer', 'prefix_id', 'suffix_id']) | ||
| && ($value == '' || !isset($value)) && | ||
| ($session->get('authSrc') & (CRM_Core_Permission::AUTH_SRC_CHECKSUM + CRM_Core_Permission::AUTH_SRC_LOGIN)) == 0 || | ||
| ($key === 'current_employer' && empty($params['current_employer']))) { |
There was a problem hiding this comment.
Current_employer should not show up anymore actually - so could probably go from above too but maybe in master
|
@MegaphoneJon you might also have an interest? |
demeritcowboy
added
the
merge ready
|
I've put merge-ready. |
|
@eileenmcnaughton looks good, merging this PR. |
|
thanks @yashodha |
|
PR for the missing help text: #26252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#4227 Fix import to not blank birth_date etc on update
Before
per
https://lab.civicrm.org/dev/core/-/issues/4227
After
Fixed according to the parameters of https://lab.civicrm.org/dev/core/-/issues/4227
Technical Details
This is some weird dark code. However, @bjendres has pin pointed that there was a behaviour change & the code is way clearer with this removed.
I initially worried that there might be an expectation at some point that the fields be blanked - but the fact an allowList is specifically configured makes it seem unlikely that this is anything other than a regression from the intended behaviour
Interestingly the test had that value set in the test.
Comments