Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some weights to menu link items #26241

Merged
merged 3 commits into from May 17, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 17, 2023

Overview

This builds on #26233 by adding some weights to core menu items. The added weights are well spread out to allow people to add between them. This does not cover all of them - it's abit tedious so I'll do some more once merged

I have been trying to consistently assign the following values to links that appear near the beginning & end respectively

  • CRM_Core_Action::VIEW -20
  • CRM_Core_Action::UPDATE -10
  • CRM_Core_Action::ENABLE 30
  • CRM_Core_Action::DISABLE 40
  • CRM_Core_Action::DELETE 100

Before

No weights

After

some

Technical Details

Comments

Docs https://lab.civicrm.org/documentation/docs/dev/-/blob/master/docs/hooks/hook_civicrm_links.md

@civibot
Copy link

civibot bot commented May 17, 2023

(Standard links)

@colemanw
Copy link
Member

Looks good.

@eileenmcnaughton
Copy link
Contributor Author

Some fails on re-ordering CRM_Contribute_Page_TabTest::testLinksPaypalStandard

Also has some fixes to get away from undeclared property issues on
touched test & helpers
@eileenmcnaughton eileenmcnaughton merged commit 0c3e959 into civicrm:master May 17, 2023
3 checks passed
@eileenmcnaughton eileenmcnaughton deleted the weight branch May 17, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants