Add missing Mailing Events to API4: Delivered, Forward, Reply #26683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
larssandergreen
force-pushed
the
Add-Mailing-delivered-to-API4
branch
from
83ced11
to
fd1433b
Compare
|
Fail looks unrelated. |
colemanw
reviewed
Jun 30, 2023
| namespace Civi\Api4; | ||
|
|
||
| /** | ||
| * TTracks when a contact replies to a mailing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is says on the tin.
Comments
I had to do some wrangling to prevent the API from using the non-standard
createmethod forCRM_Mailing_Event_DAO_MailingEventDelivered. This is the same as what @colemanw did previously toCRM_Mailing_Event_DAO_MailingEventBounce.