Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Email input as type="email" #26705

Merged
merged 1 commit into from Jul 3, 2023
Merged

Render Email input as type="email" #26705

merged 1 commit into from Jul 3, 2023

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jul 3, 2023

Overview

Enables client-side validation of the "Email" field by using the correct html type.

Fixes dev/core#4300

Before

In Afform, any value can be submitted for email

After

image

Technical Details

This updates every metadata-driven form, including Quickforms, Afforms, SearchKit bulk-update forms and in-place edit forms.

@civibot
Copy link

civibot bot commented Jul 3, 2023

(Standard links)

@civibot civibot bot added the master label Jul 3, 2023
@seamuslee001
Copy link
Contributor

Test fail relates @colemanw api\v4\SearchDisplay\SearchRunTest::testInPlaceEditAndCreate

@kcristiano
Copy link
Member

@colemanw I've installed this on a few sites that need it and have tested. an r-run shows it to work exactly as expected.

This does look good to merge.

@colemanw
Copy link
Member Author

colemanw commented Jul 3, 2023

Glad to hear it @kcristiano !

@colemanw colemanw merged commit a6b24af into civicrm:master Jul 3, 2023
3 checks passed
@colemanw colemanw deleted the email branch July 3, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants