Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default input format for credit card expiration month to NN #26768

Conversation

larssandergreen
Copy link
Contributor

@larssandergreen larssandergreen commented Jul 7, 2023

Just for new installs.

Before

Have to think.
image

After

Don't have to think. More standard, reflects what it actually says on your card.
image

Comments

It would be nice to also show the same format on the review and thank you pages for contribution and events, but crmDate doesn't support Date Preferences formats, only Date Formats, so that's a future project.

@civibot
Copy link

civibot bot commented Jul 7, 2023

Thank you for contributing to CiviCRM! ❤️ Here's what's next:

  • If this is your first PR, an admin will greenlight automated testing with the command "add to whitelist".
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command "test this please" to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • Here are some handy links for reviewers:

@civibot civibot bot added the master label Jul 7, 2023
@yashodha
Copy link
Contributor

yashodha commented Jul 9, 2023

@larssandergreen looks good, merging this PR

@yashodha yashodha merged commit e8da44c into civicrm:master Jul 9, 2023
3 checks passed
@larssandergreen
Copy link
Contributor Author

@yashodha Thanks!

@mlutfy
Copy link
Member

mlutfy commented Jul 26, 2023

I just saw this and I'm really happy :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants