Change Price paths

[aydun]

Overview

Change paths for Price Sets, Price Fields and Price Field Values

Before

After

There should be no user-visible changes, but this allows the original URL's to be overridden by AdminUI.

Technical Details

This is similar to other path changes that have been done to accommodate AdminUI.

Comments

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[colemanw]

@aydun it looks like this path is referencing an explicit join. Explicit joins don't have a stable name that can be referenced like this (since the name of the join is anything you want it to be when you call ->addJoin() in the API). Is it possible to do this with an implicit join, like [price_field_id.price_set_id]?

[aydun]

That does work for the view, update and delete links but not for the add one. Any chance you could tweak how things are processed for the add button to make that work?

[colemanw]

The ADD button processes tokens differently than links, because it doesn't have any row data to use (it's not in a row) the only data it has for tokens is the incoming filters. I know this works for a few other pages, e.g Custom Fields has an incoming filter by custom_group_id and that is passed through to the ADD button.
So if you switch your page filter to use implicit-join-style syntax then they should get passed through that way to the button.

[aydun]

Hmm - I can't get it to work for that one. Maybe there's something else not quite right in the metadata? I've changed it as you suggest. How about we merge this then come back to the add button in another PR with the new pages?

[colemanw]

Ok @aydun I'm happy to merge this but it looks like it'll need an upgrader for the navigation items.