Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone: Fix ACL help/links, tweak Users and Permissions menu #27119

Merged
merged 1 commit into from Aug 24, 2023

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Aug 22, 2023

Overview

On CiviCRM Standalone:

  • Go to Administer > Users and Permissions > Permissions
  • the "Standalone Access Control" link leads to a "fixme" 404

Also, the "Manage Users" and Roles links are not under "Users and Permissions".

This PR changes the following:

  • sets the ufAccessURL so that it leads to lead to manage "User roles"
  • tweaks the wording a bit on the Manage ACL page, so that it's less awkward when using Standalone. After all, it's not "Standalone Foo", it's just Foo. Users are aware that they are using CiviCRM, not that they are using CiviCRM Standalone.
  • moves the User Roles and User Accounts menu items under "Users and Permissions"

Before

image

Navigation menu:

image

After

image

image

Comments

Moving the menu items: I realize this hinders discoverability a bit, but I think it also declutters, therefore making menu navigation easier.

Reported by dsp3926 on the standalone chat

cc @artfulrobot

@civibot
Copy link

civibot bot commented Aug 22, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@artfulrobot
Copy link
Contributor

Thanks, this looks good pending couple of comments made on the code.

@mlutfy mlutfy force-pushed the standaloneACLNav branch 2 times, most recently from 469eafb to 16ef222 Compare August 24, 2023 16:06
@mlutfy
Copy link
Member Author

mlutfy commented Aug 24, 2023

With the latest changes, for when running inside a CMS:

image

@artfulrobot
Copy link
Contributor

Looks good to me. Thanks @mlutfy

@mlutfy
Copy link
Member Author

mlutfy commented Aug 24, 2023

Thanks @artfulrobot ! I took the liberty of adding MOP tag to the PR.

@seamuslee001 seamuslee001 merged commit c612b16 into civicrm:master Aug 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants