New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhpStorm - Add a corybantic avalanche of type-hints #27179
Conversation
Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷 Introduction for new contributors
Quick links for reviewers |
Tested, works brilliantly! |
$builder->addExpectedArguments('\civicrm_api3()', 0, 'api3Entities'); | ||
$builder->addExpectedArguments('\civicrm_api3()', 1, 'api3Actions'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you've defined a reusable set I guess it wouldn't hurt to add civicrm_api
as well (it's basically v3-only).
$builder->addExpectedArguments('\civicrm_api3()', 0, 'api3Entities'); | |
$builder->addExpectedArguments('\civicrm_api3()', 1, 'api3Actions'); | |
$builder->addExpectedArguments('\civicrm_api3()', 0, 'api3Entities'); | |
$builder->addExpectedArguments('\civicrm_api3()', 1, 'api3Actions'); | |
$builder->addExpectedArguments('\civicrm_api()', 0, 'api3Entities'); | |
$builder->addExpectedArguments('\civicrm_api()', 1, 'api3Actions'); |
I like how I've been busy ripping out APIv3 examples at the same time you were adding this. Yin an Yang 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things that make you go "meh"
Overview
Enable support for several more kinds of auto-completion. Screenshots below (alphabetical order).
Expands on #27168 and #27175. Incorporates content from #27171. ping @colemanw @mattwire
APIv3
APIv4
Event Dispatcher
Settings