phpstorm - Prefer to store generated hints in source-tree #27239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Revises the recently-added extension,
phpstorm
, to change the preferred location for generated hints. This should improve the range of compatible environments.cc @eileenmcnaughton @colemanw
Before
[civicrm.files]/.phpstorm.meta.php/*.php
tools/extensions/phpstorm/.phpstorm.meta.php
After
tools/extensions/phpstorm/.phpstorm.meta.php/*.php
(default/preferred)[civicrm.files]/.phpstorm.meta.php/*.php
(default/fallback)CIVICRM_PHPSTORM_METADATA
(manual override via civicrm.settings.php)Technical Details
These are decent folders - but not universal/awesome. Compare:
[civicrm.files]
is always writable by PHP. But it's not always visible to PhpStorm.tools/extensions/phpstorm/
is always visible to PhpStorm. But PHP is not always able to write it.If you load the patch on an existing
alpha
build where the extension has been previously installed, then you may have two copies of.phpstorm.meta.php
. This should be cleaned up by uninstalling/reinstalling the extension. (It just didn't seem worthwhile to write an upgrade task for something that's only affects the same alpha.)