Afform - Fix getting and setting boolean/numeric types

[colemanw]

Overview

Fixes: https://lab.civicrm.org/dev/core/-/issues/4465
Reviewer's cut of #27006

Technical Details

This ensures boolean and numeric fields always have the correct type set:

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

Triggering the online demo to be rebuilt: Jenkins retest this please.
FYI @xavi-xaloc

[kurund]

@colemanw

Did a quick check and the Checkbox defaults are not working for me.

[colemanw]

@kurund I reproduced... sort of. If the default is actually set, then it works. But there was a bug in the Afform_Admin GUI causing it to not be set. Fixed with 41aa7ec

Whew, this PR has been a slog. Maybe we can finally merge it!

[colemanw]

@xavi-xaloc @kurund any objection to merging this now?

[xavi-xaloc]

Sorry, @colemanw , but I can't get it work, neither locally nor in the PR link. Could you, @kurund ?

[kurund]

@colemanw @xavi-xaloc

Latest fixes are working as expected hence, merging the PR.