dev/core#4112 stop installing legacycustomsearches on new installs

[eileenmcnaughton]

Overview

dev/core#4112 stop installing legacycustomsearches on new installs

https://lab.civicrm.org/dev/core/-/issues/4112

Before

We are most of the way through separating legacy custom searches from core & we can definitely run with them disabled - so now we are ready to stop installing on new installs

After

No change on existing installs but not enabled by default on new installs

Technical Details

@seamuslee001 what more do we need to do? regen?

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4112

[demeritcowboy]

Probably here too:

civicrm-core/distmaker/core-ext.txt

Line 27 in 8114224

legacycustomsearches

[eileenmcnaughton]

I think that line puts it in the tarball - which we still want

[demeritcowboy]

ok. Then this seems fine.

[demeritcowboy]

There's an outstanding regen needed anyway from the state/province update.

[eileenmcnaughton]

@jaapjansma FYI - but I'm pretty sure you adapted your handling for the possibility of this being uninstalled about a year or so back

[jaapjansma]

@eileenmcnaughton I don't know what you are talking about. I do remember an issue with data processor and the lagacy custom search extension. But not sure which civi version that was one. I have clients which are still on Civi Version 5.37 or even Civi 5.14

By the way I don't have clients who use the latest versions of civicrm. Most of the installs are a couple of years old. Because at my clients testing an upgrade usually takes a couple of months. So they only upgrade once in the few years.

[eileenmcnaughton]

@jaapjansma ok that's fine - it was just the dependency management side of it that would have affected you earlier on