Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop enabling event_cart on new installs #27469

Merged
merged 1 commit into from Sep 18, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Stop enabling event_cart on new installs

Although we have not fully extracted this, it seems that disabling does not cause any errors, so it makes sense to stop enabling. Once we have been running like this on our dev & demo sites for a while we can disable it for any existing sites that do not have
event cart enabled

Before

Event cart core exension enabled on all installs

After

Extension no longer enabled on new installs

Technical Details

Comments

@civibot
Copy link

civibot bot commented Sep 17, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@eileenmcnaughton
Copy link
Contributor Author

CRM_Financial_Form_PaymentFormsTest::testEventPaymentForms
Failure in api call for Extension uninstall: Cannot uninstall extension; disable it first: eventcart
#0 /home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/api/v3/Extension.php(183): CRM_Extension_Manager->uninstall(Array)
#1 /home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_extension_uninstall(Array)
#2 /home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/Civi/API/Kernel.php(156): Civi\API\Provider\MagicFunctionProvider->invoke(Array)
#3 /home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/Civi/API/Kernel.php(79): Civi\API\Kernel->runRequest(Array)

Although we have not fully extracted this, it seems that disabling does not
cause any errors, so it makes sense to stop enabling. Once we have been running
like this on our dev & demo sites for a while we can disable it
for any existing sites that do not have
event cart enabled
@eileenmcnaughton eileenmcnaughton merged commit 606c43a into civicrm:master Sep 18, 2023
3 checks passed
@eileenmcnaughton eileenmcnaughton deleted the no_event_cart branch September 18, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants