New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContactSummary - Replace Notes tab with SearchKit display #27610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
colemanw
force-pushed
the
noteTabReplacement
branch
from
September 23, 2023 23:44
da6b796
to
e8146e6
Compare
colemanw
force-pushed
the
noteTabReplacement
branch
from
September 24, 2023 00:27
e8146e6
to
ccd6ae0
Compare
Tab has been replaced by SearchKit.
colemanw
force-pushed
the
noteTabReplacement
branch
from
September 24, 2023 01:28
ccd6ae0
to
b3becf5
Compare
colemanw
commented
Sep 24, 2023
@@ -7,6 +7,46 @@ | |||
| and copyright information, see https://civicrm.org/licensing | | |||
+--------------------------------------------------------------------+ | |||
*} | |||
{* This tpl is empty. Since notes is a simple form, the tpl is embedded within the parent tpl *} | |||
{* This might change in the future *} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the future 🤖 🚀 👨🏻🚀
This was referenced Sep 24, 2023
retest this please |
This was referenced Sep 26, 2023
This was referenced Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the first core tab to be replaced by SearchKit. Hopefully the first of
manyall.Before
After
Technical Details
Adds the ability to package afforms in CiviCRM core, since this tab does not logically belong in any extension.
Comments
This is the culmination of a lot of work that was all needed before this one tab could be converted:
hook_civicrm_notePrivacy
#27472civicrm/managed
directory for entity declarations #27389