dev/core#4780 handle bounce processing when verp unverified #28157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
|
The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4780 |
| $incomingMail = new CRM_Utils_Mail_IncomingMail($mail, (string) $dao->domain, (string) $dao->localpart); | ||
| } | ||
| catch (CRM_Core_Exception $e) { | ||
| continue; |
There was a problem hiding this comment.
if we are getting an error should we be calling $store->markIgnored($key) ?
|
@lcdservices can you put this against 5.68 rc branch as a regression? |
|
closing in deference to: #28192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When cycling through bounced emails, the current behavior is to exit with a fatal error if Verp handling is enabled and the email is not verified. This effectively prevents any bounces from processing. Instead we should skip the problem email and continue processing.
Before
Bounce processing exits with a fatal error.
After
Bounce record is skipped and processing continues.