Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Premium Product v4 api #28261

Merged
merged 3 commits into from Nov 23, 2023
Merged

Add Premium Product v4 api #28261

merged 3 commits into from Nov 23, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

No description provided.

Copy link

civibot bot commented Nov 21, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@eileenmcnaughton
Copy link
Contributor Author

I added Premiums api in the hope it addresses this

(fun fact premiums is our only plural entity)

Test Result (1 failure / +1)
api\v4\Entity\ConformanceTest.testConformance with data set "PremiumsProduct"

@eileenmcnaughton
Copy link
Contributor Author

sigh - this one is a bit of a fight - test fails on entity_id - I guess I need to add a list of availble to the Product entity - - I wonder what entities are possible

@colemanw I note that the tables are

civicrm_premiums
civicrm_premiums_product

Based on the BAO the entities are Premium and PremiumsProduct - it's bit inconsistent with the plurals but have just followed the BAO for now.

@seamuslee001 seamuslee001 merged commit d065881 into civicrm:master Nov 23, 2023
3 checks passed
@seamuslee001 seamuslee001 deleted the prod branch November 23, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants