New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone - remove role from users on deletion #28429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
@artfulrobot another one for you to review. |
wmortada
force-pushed
the
standalone-roles3
branch
from
December 2, 2023 19:13
1469bdf
to
1f0d191
Compare
artfulrobot
reviewed
Dec 2, 2023
Will r-run it tomorrow. Night! |
wmortada
force-pushed
the
standalone-roles3
branch
from
December 3, 2023 11:31
1f0d191
to
261adaf
Compare
Rebased to resolve merge conflict. |
I tested this by adding 2 roles to a user, deleting one of the roles. The user record was left with just the one role. Looks great. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When deleting a user role, this role should be removed from all users that have the role.
Before
When a role is deleted, users with this role still have the role.
After
When a role is deleted, it is also removed from all users with the role.
Comments
I've included an commit from @colemanw to avoid merge conflicts. This PR should be merged after #28422.