Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone - remove role from users on deletion #28429

Merged
merged 1 commit into from Dec 4, 2023

Conversation

wmortada
Copy link
Contributor

@wmortada wmortada commented Dec 2, 2023

Overview

When deleting a user role, this role should be removed from all users that have the role.

Before

When a role is deleted, users with this role still have the role.

After

When a role is deleted, it is also removed from all users with the role.

Comments

I've included an commit from @colemanw to avoid merge conflicts. This PR should be merged after #28422.

Copy link

civibot bot commented Dec 2, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 2, 2023
@wmortada
Copy link
Contributor Author

wmortada commented Dec 2, 2023

@artfulrobot another one for you to review.

@artfulrobot
Copy link
Contributor

Will r-run it tomorrow. Night!

@wmortada
Copy link
Contributor Author

wmortada commented Dec 3, 2023

Rebased to resolve merge conflict.

@artfulrobot
Copy link
Contributor

I tested this by adding 2 roles to a user, deleting one of the roles. The user record was left with just the one role.

Looks great. Merging.

@artfulrobot artfulrobot merged commit 861d321 into civicrm:master Dec 4, 2023
3 checks passed
@wmortada wmortada deleted the standalone-roles3 branch December 4, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants