Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applies accessible accordion to contact dashboard, replaces old accordion pattern #28430

Merged
merged 1 commit into from Dec 3, 2023

Conversation

vingle
Copy link
Contributor

@vingle vingle commented Dec 2, 2023

Makes the contact dashboard accordions for custom fields accessible using the <details><summary> pattern. Has the added advantage of replacing a less common Civi accordion pattern .crm-collapsible (accordion3 in ThemeTest) - but achieves this by changing the class name.

Before

Custom field accordions aren't keyboard controllable
image

After

They are:
image

Technical Details

To make this match it's appearance in Grenwich, the class .crm-master-accordion-header is added to summary to make it transparent (as used accordion8).

Comments

Might impact 3rd party themes as it's changed class names, so flagging it in chat.civicrm.org/theme-maintainers .

Any extension targeting those old class names would also be impacted, tho don't know of any.

Makes the contact dashboard accordions for custom fields accessible using the <details><summary> pattern.
Copy link

civibot bot commented Dec 2, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@wmortada
Copy link
Contributor

wmortada commented Jan 26, 2024

@vingle the logic for the accordion being opened or collapsed was inverted. I've fixed in #29091.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants