Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standalone: implement User fields when_last_accessed and when_updated #28440

Conversation

artfulrobot
Copy link
Contributor

When last accessed tracks when the logged in user last made a PHP request to the site, limited to one update per minute.

When updated tracks when a user record was updated.

Copy link

civibot bot commented Dec 3, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 3, 2023
@artfulrobot
Copy link
Contributor Author

Mentioning people who may be interested @wmortada @jaapjansma

When last accessed tracks when the logged in user last
made a PHP request to the site, limited to one update per minute.

When updated tracks when a user record was updated.
@artfulrobot artfulrobot force-pushed the artfulrobot-standalone-user-timestamps branch from 3c5a6c4 to d89f36c Compare December 3, 2023 13:21
@jaapjansma
Copy link
Contributor

Looks good to me. I am not sure why the test is failing.

@artfulrobot
Copy link
Contributor Author

Merging thanks for review.

@artfulrobot artfulrobot merged commit 2b764d7 into civicrm:master Dec 3, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants