Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newui badged layout #28518

Closed
wants to merge 3 commits into from
Closed

Newui badged layout #28518

wants to merge 3 commits into from

Conversation

wyde22
Copy link
Contributor

@wyde22 wyde22 commented Dec 5, 2023

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.
new screen with searchkit and formbuilder

Before

old quickform screen

After

a searchkit with a formbuilder. There is the old form in action link (edit and disable)

Technical Details

When the setting of badge is reserved i show the action button disable and delete. For this screen i think the disable link is not necessary. It's possible to disable / enable the badge with edit action

Comments

Copy link

civibot bot commented Dec 5, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civicrm-builder
Copy link

Can one of the admins verify this patch?

1 similar comment
@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot civibot bot added the master label Dec 5, 2023
@eileenmcnaughton
Copy link
Contributor

add to whitelist

@aydun aydun self-assigned this Dec 7, 2023
Comment on lines +9 to +10
'server_route' => 'civicrm/searchkit_ui/admin/badgelayout',
'modified_date' => '2023-12-05 09:31:54',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'server_route' => 'civicrm/searchkit_ui/admin/badgelayout',
'modified_date' => '2023-12-05 09:31:54',
'server_route' => 'civicrm/searchkit_ui/admin/badgelayout',

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified date doesn't belong in a packaged form. I've also opened totten/civix#322 to fix this upstream.

@samuelsov
Copy link
Contributor

samuelsov commented Mar 2, 2024

Superseded by #29588

@samuelsov samuelsov closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants