[WIP] Find tests that cover admin forms so that they can be converted too 😈

[demeritcowboy]

Overview

Sledgehammer approach that won't find everything but might find some.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

So this is good to merge then....

[demeritcowboy]

Haha!
Yeah that's disappointing, but I know there's more than one test so that must be the wrong approach. Let's try something different...

[eileenmcnaughton]

Have you considered the right exception here might be CRM_Core_Exception() - any total site breakage should be Civi-specific IMHO

[demeritcowboy]

I think from here on targeting the specific forms that were converted might be a better way to find them.

This is a good enough start, and I made the mixin tests fail for REAL earlier, which is a bonus.

Will transfer to a lab ticket. EDIT: https://lab.civicrm.org/dev/core/-/issues/4850

CRM_Activity_Form_SearchTest.testSearch
CRM_Admin_Form_PaymentProcessorTest.testUpdateAcceptCreditCard
CRM_Core_FormTest.testOpeningForms with data set "Location Type"
CRM_Core_FormTest.testOpeningForms with data set "Message Templates"
CRM_Core_FormTest.testOpeningForms with data set "Scheduled Jobs"
CRM_Core_OptionGroupTest.testSanitizeFromEmailAddress with data set #0
CRM_Core_OptionGroupTest.testSanitizeFromEmailAddress with data set #1
CRM_Core_OptionGroupTest.testSanitizeFromEmailAddress with data set #2