Add param check before use getFieldOptions

[wikimediaWfan]

Overview

See some type error as "TypeError: Argument 1 passed to CRM_Core_BAO_CustomField::getFieldOptions() must be of the type int, null given"

Before

use getFieldOptions without check the passing params, like if id is null, then we could not locate the cacheKey

After

Only fetch the field options if id, datatype, and entity not null, to avoid the typeError

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[yashodha]

@wikimediaWfan Can you please share steps to replicate this?

[colemanw]

Reading the code, it looks like you'd only hit an error like this if the field does not exist.
@wikimediaWfan did you get a backtrace on what code called this function with a nonexistent field id?

[eileenmcnaughton]

Closing this as it turned out it was flagging a bug in extended reports (fixed in master)