[php8.2] compliant ajax method for custom data on pledge form

[eileenmcnaughton]

Overview

Use php8.x compliant ajax method for custom data on pledge form

Before

The pledge form is loading custom data in a way which is not php8.2 compliant & calls 3 toxic functions to do so

After

The Custom data is loaded by ajax. I ensured that it works with other currency separators in the process (hence the odd ampersands)

Technical Details

I tested on both new & edit

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[jitendrapurohit]

Deleting a pledge results into a database error after this change.

Perhaps, $this->_id should be replaced with getPledgeId() at https://github.com/civicrm/civicrm-core/blob/master/CRM/Pledge/Form/Pledge.php#L415?

[eileenmcnaughton]

thanks @jitendrapurohit I didn't realise delete would be affected - I just pushed up to use getPledgeID() in all the places ->_id is referenced

[eileenmcnaughton]

@jitendrapurohit I also put up #29701 to address that screed of red notices I saw

[jitendrapurohit]

Have completed r-run and and everything appears to be good during testing 👍

[eileenmcnaughton]

thanks @jitendrapurohit - merging based on your review