Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing test in PR runs for now #29242

Merged
merged 1 commit into from Feb 4, 2024

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

All tests are failing on this today - let's suppress it for now - we can unsuppress once resolved but this test is really gonna rely on @totten or @mlutfy to resolve

Copy link

civibot bot commented Feb 4, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Feb 4, 2024
@eileenmcnaughton eileenmcnaughton merged commit 427461d into civicrm:master Feb 4, 2024
3 checks passed
@mlutfy
Copy link
Member

mlutfy commented Feb 5, 2024

@eileenmcnaughton @totten I think we can completely remove this test, since civicrm-setup does not require these files anymore? (towards deprecating the old installer)

@eileenmcnaughton
Copy link
Contributor Author

It wouldn't be missed....

@totten
Copy link
Member

totten commented Feb 7, 2024

(@mlutfy) I think we can completely remove this test, since civicrm-setup does not require these files anymore? (towards deprecating the old installer)

I'd agree that the files are deprecated - but in my copy of universe, all variants of civicrm.drush.inc still use $sqlPath . '/civicrm_data.' . $lang . '.mysql'. I don't think they're inert yet? (Does Aegir still rely on that the installer from civicrm.drush.inc?)

@mlutfy
Copy link
Member

mlutfy commented Feb 7, 2024

@totten Yep good point - I opened an issue here: https://lab.civicrm.org/dev/drupal/-/issues/193

and created a few PRs to work towards that.

Aegir does not use this code for Drupal8+, but for Drupal7 it was still being used. I don't think many people use it though, except .. CiviCRM Spark and a handful of Symbiotic clients.

@totten
Copy link
Member

totten commented Feb 8, 2024

This was backported to 5.69, so it may show up in those release-notes. Just noting that I think the test-failure points to a data problem. I've split off separate issue about that (https://lab.civicrm.org/dev/translation/-/issues/84). For 5.69.5, I'm planning to manually override civicrm-5.69.5-l10n.tar.gz with the dataset from 5.69.4 (with adapted version-number).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants