Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Contact Summary Events tab with Admin UI Search Display and Form #29570

Merged
merged 3 commits into from Mar 3, 2024

Conversation

guyiac
Copy link
Contributor

@guyiac guyiac commented Mar 1, 2024

Overview

Replace Contact Summary Events tab with Admin UI Search Display and Form per Coleman's request

Before

Standard Events Tab

After

Events tab of Contact Summary is a Search Display in a FormBuilder Form

Technical Details

Pretty straightforward

Comments

First commit ever. Be kind.

@civicrm-builder
Copy link

Can one of the admins verify this patch?

1 similar comment
@civicrm-builder
Copy link

Can one of the admins verify this patch?

Copy link

civibot bot commented Mar 1, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Mar 1, 2024
@seamuslee001
Copy link
Contributor

Jenkins add to whitelist

@kcristiano
Copy link
Member

jenkins test this please

@colemanw
Copy link
Member

colemanw commented Mar 2, 2024

Ok I've reviewed, tested & cleaned this up, using a linksProvider callback to give the multiple register + credit card buttons.
The one thing I removed is the self-service "Transfer or Cancel" link which seems more appropriate to the front-end than the backend. I see it was added in #10695 but I still don't understand the use-case for it. It's still accessible by clicking the "View" link and then the self-service button is there... maybe that's good enough for whoever wanted it added?

@guyiac
Copy link
Contributor Author

guyiac commented Mar 2, 2024

Ok I've reviewed, tested & cleaned this up, using a linksProvider callback to give the multiple register + credit card buttons. The one thing I removed is the self-service "Transfer or Cancel" link which seems more appropriate to the front-end than the backend. I see it was added in #10695 but I still don't understand the use-case for it. It's still accessible by clicking the "View" link and then the self-service button is there... maybe that's good enough for whoever wanted it added?

Isn't there a use case for an admin transferring or cancelling a registration if someone calls or shows up at the front desk?

@eileenmcnaughton
Copy link
Contributor

@colemanw this has passed & is MOP but just want to check that you have seen @guyiac's comment

Checks permissions and conditionally adds a credit card registration link
I don't know what purpose this serves, but it was added in civicrm#10695
so this keeps the new screen true to the old one.
@colemanw
Copy link
Member

colemanw commented Mar 3, 2024

@guyiac @eileenmcnaughton ok I have added the self-serve link back in.

@colemanw colemanw merged commit 5a526df into civicrm:master Mar 3, 2024
3 checks passed
@francescbassas
Copy link
Contributor

This introduces a little regression. Someone can review it? #30086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants