dev/core#5118 Add support for trailing conditional bracket [wip - regex not quite right]

[eileenmcnaughton]

Overview

Add support for trailing conditional bracket in tokens - eg * {contact.first_name}{ }{contact.last_name}{ (}{contact.nick_name}{)}*

Before

After

Technical Details

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[aydun]

@eileenmcnaughton here's a slightly different approach: https://gist.github.com/aydun/5e5da42e1425ce1740ff419e282c3739 What else should it allow for?

[eileenmcnaughton]

Oh wow @aydun good work. One thing to be a little mindful of is that there is some risk in passing a string through regex multiple times of allowing someone to create executable code - personally I don't know if how one would do it if unable to pass in & < > so I think we are fine - I just wanted to put that on the radar in terms of being less instead of more here.

Note these will work in any smarty-rendered token string unlike the previous implementation.

What are the next steps - should I close this for you to replace?

[aydun]

@eileenmcnaughton I've opened #30099 as an alternative