CRM-14367 make pdf option dependent on site setting #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As an aside - adding these options to any other pdf letter task (ie. send by email where available) should be as 'simple' as adding the field edited in this commit to the form - Potentially in the Page format default |
davecivicrm
added a commit
that referenced
this pull request
May 6, 2014
CRM-14367 make pdf option dependent on site setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davecivicrm here is the patch for #2 in your fixes on the pdf letter options. I am leaving this for you to merge or not because I have a couple of misgivings about it
the replacement of the pdf library done by others on the sprint seems to me to mitigate the performance issues that brought about the setting in the first place
the setting description is
If enabled, CiviCRM sends PDF receipt as an attachment during event signup or online contribution. which seems a little misleading & could be set for reasons other than the performance issue
Having said that - I am not strongly one way or the other - so merge or reject this PR as you see fit