CRM-17859 - import contacts from CSV: sanitise / cleanup non-breaking… #7813
Conversation
saurabhbatra96
force-pushed
the
CRM-17859
branch
from
ffb96e7
to
3d99f8b
Compare
| */ | ||
| function trim_nbsp($string) { | ||
| return trim($string, chr(0xC2) . chr(0xA0)); | ||
| } |
There was a problem hiding this comment.
Instead of placing this function in the global scope, I would suggest putting it in this class (or CRM_Utils_String). Or maybe easiest & simplest for now would be to make it an anonymous function and pass it straight into array_map.
saurabhbatra96
force-pushed
the
CRM-17859
branch
from
3d99f8b
to
9d15d2b
Compare
|
@colemanw I shifted the function to the CRM_Utils_String class. |
saurabhbatra96
force-pushed
the
CRM-17859
branch
from
9d15d2b
to
9bfeeed
Compare
|
Ok now that it's a general utility function, I'm wondering... does this function do anything other than remove |
|
The "usual" whitespace characters are handled well by the standard trim function. I think if any other peculiar whitespace characters were to be reported later on, those could easily be added to this function. |
|
FYI Civicrm requires php 5.3+ |
|
Well. Did not know that. In that case I'll shift it to an anonymous function. Neat! |
saurabhbatra96
force-pushed
the
CRM-17859
branch
from
9bfeeed
to
7571965
Compare
|
I believe the test failures are unrelated. |
|
Jenkin, test this please |
|
#test #import I was able to replicate this by creating some html with   at the end of the email address & copying to an open office spreadsheet & saving as csv. the resulting csv would not import |
|
I can confirm that after applying this patch I was able to complete the import |
|
I had some success replicating this in a unit test - see https://github.com/civicrm/civicrm-core/pull/8113/files |
… spaces from records
https://issues.civicrm.org/jira/browse/CRM-17859