CRM-18756: TrackableURLOpen: fix SQL parameter escaping convention. #8516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mlutfy
commented
Jun 6, 2016
•
mlutfy
commented
- CRM-18756: Mailing URL redirection: use CRM_Utils_Rule::mysqlColumnNameOrAlias()
|
I reproduced the testing steps from CRM-17959 to make sure that adding the SQL validation code didn't break anything, and added a test for CRM-17959. Seems OK. |
|
Looking over this, this looks fine to me and i think is ok to be merged. @eileenmcnaughton do you think this is ok? as far as I can tell it isn't actually changing the effect of any of the code just making it more secure |
|
I just tested this by putting it on a site & then clicking on a trackable url from an email - the url worked & took me through to the destination - I think this proves it doesn't break anything - so merging. I agree with Seamus's reading of the code wp-content/plugins/civicrm/civicrm/extern/url.php?u=72&qid=8758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.