SOAP Authentication Fails on WP (4.7) #8787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-19154: SOAP Authentication Fails on WP https://issues.civicrm.org/jira/browse/CRM-19154 * CRM-13007: SOAP authentication fails on WP with CCRM 4.3+ https://issues.civicrm.org/jira/browse/CRM-13007
|
See also #8786 for 4.6. |
|
Jenkins re test this please |
|
ping @kcristiano Kevin does this seem sensible, Just figure given you have done a bunch of work on wordpress stuff lately you would know. |
|
@seamuslee001 @kcristiano you also might take a look at the description from CRM-19154: basically this change was in 4.3 but a glitch meant that it never got carried into 4.4 or later. |
|
@seamuslee001 @agh1 I agree, I read through and the patch is sane - it should be in. In fairness, I have not tested, but this should get in 4.7.10 if at all possible |
|
I'm going to merge this based on Kevin's comments & the fact the line seems to have been accidentally dropped. I have no idea how to test this though :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-19154
https://issues.civicrm.org/jira/browse/CRM-13007