CRM-19154, CRM-18808 - Add E2E tests for web-service end-points. SOAP/REST fixes. #8914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totten
changed the title
This function call bombs (on Drupal) because the method is not really static. Need this to work so we can have a test...
Now-a-days, HTTP headers are outputted using CMS functions, which means that the CMS must always boot -- even if you're only displaying an error message. This caused regressions in the REST error handling. Why? The boot sequence is really quirky with the REST calls... and the required CMS functions were not always available. This revision ensures that (one way or another) the CMS does get booted. Notably, though, in the error scenarios, it boots *without* loading or authenticating a user.
|
Note: Rebased. Updated commit notes to reference CRM-18808 and tweaked README.md. |
|
This main patch for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the regressions of CRM-19154, this PR adds a new suite,
E2E_AllTests, for end-to-end integration tests of backend scripts likeextern/soap.phpandextern/rest.php.Note: I've updated Jenkins (
CiviCRM-Core-PR) to executeE2E_AllTestsifit is available. Jenkins will run it on Drupal (because that's the test
site it creates); however, I'm hoping/expecting it will also run on WP.
While working on the test, I hit upon some bugs/regressions in the
extern/soap.phpandextern/rest.phpend-points. These have patchesincluded.