Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-17422: Backport #7007 to 4.6 #9022

Closed
wants to merge 1 commit into from
Closed

CRM-17422: Backport #7007 to 4.6 #9022

wants to merge 1 commit into from

Conversation

omarabuhussein
Copy link
Member

@omarabuhussein omarabuhussein commented Sep 13, 2016

@omarabuhussein
Copy link
Member Author

omarabuhussein commented Sep 13, 2016

@monishdeb @eileenmcnaughton I tagged you guys since you are originally discussed the issue on #7007 .. what do you think ?

@eileenmcnaughton
Copy link
Contributor

If it backported cleanly & you have tested against 4.6 I'm happy to merge it

@monishdeb
Copy link
Member

monishdeb commented Sep 13, 2016

yup like @eileenmcnaughton said, if the backport patch fixes the original issue CRM-17422 then its ready to merge. @omarabuhussein have you tested the fix on 4.6 latest ?

@omarabuhussein
Copy link
Member Author

thanks guys ,, I didn't really tested it on latest 4.6 but on a bit older one ... will test again on latest 4.6 and then compare the changes with current code on master and let you know

@colemanw
Copy link
Member

@omarabuhussein have you tested this yet?

@omarabuhussein
Copy link
Member Author

@colemanw Yes and it work .. but there are many changes happened in this part of code in 4.7 so I want to trace the commit history and try to make the code similar as much as possible to the current code in 4.7 ... I also working on fixing a case where custom field type is a multi select box so this can wait a bit.

@colemanw
Copy link
Member

Ok, lets reopen this when you're ready.

@colemanw colemanw closed this Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants