Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in CRM-19490 where input field wasn't being properly set #9530

Merged

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Dec 12, 2016

@gemmapotaka
Copy link

gemmapotaka commented Dec 12, 2016

Have tested this and I am no longer seeing the error :) that triggered this fix

@eileenmcnaughton
Copy link
Contributor

I'm merging this based on Gemma's testing & discussion with Seamus. Seamus did the original fix & says he inadvertently dropped some extra html. There was testing of the original fix but this was not picked up. Since Seamus did the original fix he understands it enough to ensure that part did not regress

@davejenx pinging you FYI

@eileenmcnaughton eileenmcnaughton merged commit 29cbd60 into civicrm:master Dec 12, 2016
@petednz
Copy link

petednz commented Dec 18, 2016

where does this stand with regard to 4.6.x?

@seamuslee001
Copy link
Contributor Author

@petednz Pete, I don't think this nor the original fix has been backported to 4.6.x Maybe worthwhile looking into doing that, I might with my week off next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants