Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards CRM-19815 Fix misdisplay of gender on drupal user-view page as a result of previous work on this within this release #9908

Merged
merged 1 commit into from
Feb 28, 2017

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Feb 28, 2017

Note that the click-throughs still do not work but this turns out to be
a pre-existing issue so I will leave that for a follow up


Note that the click-throughs still do not work but this turns out to be
a pre-existing issue so I will leave that for a follow up
@eileenmcnaughton eileenmcnaughton changed the title CRM-19815 Fix misdisplay of gender on drupal user-view page Towards CRM-19815 Fix misdisplay of gender on drupal user-view page Feb 28, 2017
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 this is the regression I mentioned as a result of work towards making the pseudoconstant handling generic (& hence available to resolve contribution search issues).

The issue is the gender field on the profile view listing on the drupal user edit page was showing 1 for Gender, not Female.

This causes it to show correctly. However, the click through searches don't work. I established this as being an issue on 4.7.16rc branch (& I think earlier) so I'm not treating that as a regression & it can go into master not the rc (possibly on a separate ticket)

@eileenmcnaughton eileenmcnaughton changed the title Towards CRM-19815 Fix misdisplay of gender on drupal user-view page Towards CRM-19815 Fix misdisplay of gender on drupal user-view page as a result of previous work on this Feb 28, 2017
@eileenmcnaughton eileenmcnaughton changed the title Towards CRM-19815 Fix misdisplay of gender on drupal user-view page as a result of previous work on this Towards CRM-19815 Fix misdisplay of gender on drupal user-view page as a result of previous work on this within this release Feb 28, 2017
@seamuslee001
Copy link
Contributor

PR fixes problem identified in testing and looks fine

@totten
Copy link
Member

totten commented Feb 28, 2017

Thanks, @seamuslee001. Merging per Mattermost discussion.

@totten totten merged commit 63a8344 into civicrm:master Feb 28, 2017
@eileenmcnaughton eileenmcnaughton deleted the regress branch February 28, 2017 03:08
monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
Towards CRM-19815 Fix misdisplay of gender on drupal user-view page as a result of previous work on this within this release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants