Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BASW-379: Fix CiviCRM action item icons #360

Merged

Conversation

igorpavlov-zz
Copy link
Contributor

@igorpavlov-zz igorpavlov-zz commented Feb 13, 2019

Overview

This PR fixes the issue with actions icons in CiviCRM.

Before

image

After

image

Technical description

The problem is at scss/civicrm/common/_buttons.scss:

...
.crm-hover-button,
... {
  @extend %btn;
}

The %btn changes the font to OpenSans while it should be kept as FontAwesome but only for icons, so:

.crm-hover-button.crm-i {
  font-family: $font-family-fontawesome !important;
  // !important is needed because %btn contains !important too
}

is a safe way to keep the font correct and do not produce regressions.

Tests

This is an extremely minor change, so only manual tests were performed to save time.

Copy link
Member

@monishdeb monishdeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working fine:
screen shot 2019-02-19 at 12 26 12 pm

@monishdeb
Copy link
Member

Tested working fine. Based on two approval I am merging this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants