Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css for kam smartmenu #364

Closed
wants to merge 1 commit into from
Closed

Conversation

colemanw
Copy link
Member

Fixes #342

I understand there are minor style differences between KAM and the Shoreditch menu, notably the height (41px vs 60px) and the color (white on lightgrey vs white on white) however if we don't merge this Shoreditch will be broken so I suggest we think about style tweaks later and get this merged in sooner.

@colemanw
Copy link
Member Author

@AkA84 ping

@colemanw
Copy link
Member Author

colemanw commented Mar 7, 2019

@AkA84 @jamienovick I understand there are some discussions to be had about tweaking the style of the new KAM menu. But whether or not we do that, this PR is required. Please merge.

@igorpavlov-zz
Copy link
Contributor

The PR looks clean to me. cc @AkA84

@AkA84
Copy link
Contributor

AkA84 commented Mar 13, 2019

thanks @igorpavlov , but this PR is not to be merged yet, will do myself when we're ready for it

@jamienovick
Copy link

@AkA84 do you think we can get this styled as per Shoreditch also... Hate to be a pain but it is the small things that will make the difference.

@colemanw
Copy link
Member Author

colemanw commented Mar 13, 2019

@jamienovick I just want to warn you that changing the height of the menu bar would be quite difficult.
Because CiviCRM core does not use SCSS (maybe it should but that's a different conversation) we don't have a single variable defined like $menuHeight = 40px. So there are many, many places in many core css files that do calculations based on the current height of 40px. If you grep the css files for "40px" or "80px" "120px" etc. you'll find an overwhelming number of results. Too many for Shoreditch to safely attempt to mess with IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all menubar css and js
4 participants