Allow for System Admins to disable the Shoreditch loading of bootstra… #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p JS if they have another source of bootstrap js
deb1990
force-pushed
the
disable_bootstrap_js
branch
2 times, most recently
from
407398e
to
5643d63
Compare
deb1990
force-pushed
the
disable_bootstrap_js
branch
from
5643d63
to
72eb705
Compare
deb1990
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…p JS if they have another source of bootstrap js
The problem I ran into was that on a client site they have a theme based on the Bootstrap Drupal 7 theme, This theme fetches the Bootsrap js and css as well as Shoreditch. What this consequently meant was that when using the new search kit extension there was a conflict between the 2 versions of Bootstrap JS and subsequently causing dropdown menus to not show. This adds in a setting and form to give system admins the ability to disable the Shoreditch bootstrap js loading.