Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenJDK to 11.0.14.1 #2316

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Update OpenJDK to 11.0.14.1 #2316

merged 4 commits into from
Apr 26, 2022

Conversation

rasmi
Copy link
Contributor

@rasmi rasmi commented Apr 20, 2022

See Issue #2315 for context. This only updates the x86/amd64 version, and does not bump the arm64 version, since it is not yet available. arm64 is not urgent (to my knowledge) since it is only used for local Mac M1 development.

Fixes (in part) issue #2315.

See #2315. This only updates  the x86/amd64 version, and does not bump the arm64 version, since it is [not yet available](https://hub.docker.com/r/bellsoft/liberica-openjdk-alpine/tags). arm64 is not urgent (to my knowledge) since it is only used for local Mac M1 development.
@rasmi rasmi requested a review from bion April 20, 2022 14:03
@rasmi
Copy link
Contributor Author

rasmi commented Apr 20, 2022

It looks like past commits for arm64 bumped to 11.0.14 then reverted back -- I'm not sure why (incompatibility with other dependencies?), but we may need to resolve the underlying issue there if there was one.

@bion
Copy link
Contributor

bion commented Apr 20, 2022

Upgrading to 11.0.14.x hits a compiler error for Java. It looks like it's probably related to a bugfix in OpenJDK that detects "." in names in zip files and throws an exception in order to avoid an infinite loop. Unfortunately this change appears to break our build.

It doesn't appear this is broadly an issue with Play Framework or SBT -- there are no github issues related to this error in either project, and OpenJDK 11.0.14 has been out since January.

I tried building the hello world Play Framework demo with our Dockerfile and it worked both with our current version of OpenJDK as well as 11.0.14.1, which further suggests there's something particular to how we're building civiform specifically that is producing this problem.

Copy link
Contributor

@bion bion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the compiler error before merging

@bion bion marked this pull request as draft April 20, 2022 18:55
@bion bion mentioned this pull request Apr 20, 2022
@bion
Copy link
Contributor

bion commented Apr 21, 2022

The issue appears to be our use of webjars, removing these lines fixes the problem: https://github.com/seattle-uat/civiform/blob/main/universal-application-tool-0.0.1/build.sbt#L142-L144

Will need to figure out a different way to load the azure storage JS library.

@bion bion marked this pull request as ready for review April 26, 2022 16:49
@bion bion enabled auto-merge (squash) April 26, 2022 16:50
@bion bion merged commit b7c9878 into main Apr 26, 2022
@bion bion deleted the openjdk-update branch April 26, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants