-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenJDK to 11.0.14.1 #2316
Conversation
See #2315. This only updates the x86/amd64 version, and does not bump the arm64 version, since it is [not yet available](https://hub.docker.com/r/bellsoft/liberica-openjdk-alpine/tags). arm64 is not urgent (to my knowledge) since it is only used for local Mac M1 development.
It looks like past commits for arm64 bumped to 11.0.14 then reverted back -- I'm not sure why (incompatibility with other dependencies?), but we may need to resolve the underlying issue there if there was one. |
Upgrading to 11.0.14.x hits a compiler error for Java. It looks like it's probably related to a bugfix in OpenJDK that detects "." in names in zip files and throws an exception in order to avoid an infinite loop. Unfortunately this change appears to break our build. It doesn't appear this is broadly an issue with Play Framework or SBT -- there are no github issues related to this error in either project, and OpenJDK 11.0.14 has been out since January. I tried building the hello world Play Framework demo with our Dockerfile and it worked both with our current version of OpenJDK as well as 11.0.14.1, which further suggests there's something particular to how we're building civiform specifically that is producing this problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix the compiler error before merging
The issue appears to be our use of webjars, removing these lines fixes the problem: https://github.com/seattle-uat/civiform/blob/main/universal-application-tool-0.0.1/build.sbt#L142-L144 Will need to figure out a different way to load the azure storage JS library. |
See Issue #2315 for context. This only updates the x86/amd64 version, and does not bump the arm64 version, since it is not yet available. arm64 is not urgent (to my knowledge) since it is only used for local Mac M1 development.
Fixes (in part) issue #2315.