Use CDN to load azure blob browser lib #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clouser2
approved these changes
Apr 25, 2022
| @@ -105,7 +105,7 @@ public Tag renderFileUploadBlockSubmitForms( | |||
| return div(formTag, skipForms, buttons) | |||
| .withId("azure-upload-form-component") | |||
| .with( | |||
| footer(viewUtils.makeWebJarsTag(WebJarJsPaths.AZURE_STORAGE_BLOB)), | |||
There was a problem hiding this comment.
Looks good. Is it worth creating a separate issue tracking reverting to this path once the Azure issue is fixed upstream? We could then add a TODO against it here.
clouser2
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using https://webjars.org to load javascript libraries (just one so far) but the azure blob storage library specifically causes a Java compilation error on the latest patch version of Java 11.
This change is to unblock upgrading to Java 11.0.14 while we figure out how to resolve the webjar problem.
Unblocks #2316, #2315