Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Program Card Images] Add breadcrumbs to admin program image upload page #6254

Merged
merged 11 commits into from
Dec 27, 2023

Conversation

caitlinshk
Copy link
Collaborator

@caitlinshk caitlinshk commented Dec 21, 2023

Description

This PR makes use of the USDWS breadcrumb component to add breadcrumbs to the admin program image upload page. The breadcrumbs are "Edit programs > {Program Name} > Program Image Upload". It defines a generic BreadcrumbFactory class that can create breadcrumbs for any content. Right now, ProgramImageView is the only class using BreadcrumbFactory but I expect BreadcrumbFactory will be used by other pages in the future.

Here is the Figma with the breadcrumbs design.

Release notes

Checklist

General

Read the full guidelines for PRs here

  • Added the correct label: < feature | enhancement | bug | dependencies | infrastructure | ignore-for-release | database >
  • Assigned to a specific person, civiform/developers, or a more specific round-robin list.
  • Created unit and/or browser tests which fail without the change (if possible)
  • Performed manual testing (Chrome and Firefox if it includes front-end changes)

User visible changes

  • Manually tested at 200% size
  • Manually evaluated tab order

New Features

Instructions for manual testing

  1. Enable the PROGRAM_CARD_IMAGES flag.
  2. As an admin, edit a program then click the "Edit program image" button.
  3. Verify the program image page has breadcrumbs (as shown in the screenshots).

Issue(s) this completes

Epic #5676

Sub-task #5999

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9f8449) 81.60% compared to head (9f6a037) 81.60%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6254   +/-   ##
=========================================
  Coverage     81.60%   81.60%           
  Complexity     3391     3391           
=========================================
  Files           415      415           
  Lines         14654    14654           
  Branches        962      962           
=========================================
  Hits          11958    11958           
  Misses         2288     2288           
  Partials        408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from caitlinshk_program_image_preview to main December 21, 2023 22:15
@caitlinshk caitlinshk changed the title Add breadcrumbs to admin program image upload page [Program Card Images] Add breadcrumbs to admin program image upload page Dec 27, 2023
@caitlinshk caitlinshk added the feature A significant new feature or functionality label Dec 27, 2023
@caitlinshk caitlinshk marked this pull request as ready for review December 27, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A significant new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants