-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Program Card Images] Add breadcrumbs to admin program image upload page #6254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2023
Merged
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
caitlinshk
force-pushed
the
caitlinshk_pci_breadcrumb
branch
from
December 21, 2023 22:00
a0a2f68
to
a349aa8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6254 +/- ##
=========================================
Coverage 81.60% 81.60%
Complexity 3391 3391
=========================================
Files 415 415
Lines 14654 14654
Branches 962 962
=========================================
Hits 11958 11958
Misses 2288 2288
Partials 408 408 ☔ View full report in Codecov by Sentry. |
caitlinshk
force-pushed
the
caitlinshk_pci_breadcrumb
branch
from
December 26, 2023 22:27
79b0b6f
to
ce88853
Compare
caitlinshk
changed the title
Add breadcrumbs to admin program image upload page
[Program Card Images] Add breadcrumbs to admin program image upload page
Dec 27, 2023
5 tasks
yotommy
reviewed
Dec 27, 2023
yotommy
reviewed
Dec 27, 2023
yotommy
reviewed
Dec 27, 2023
yotommy
reviewed
Dec 27, 2023
yotommy
reviewed
Dec 27, 2023
yotommy
reviewed
Dec 27, 2023
yotommy
approved these changes
Dec 27, 2023
This was referenced Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes use of the USDWS breadcrumb component to add breadcrumbs to the admin program image upload page. The breadcrumbs are "Edit programs > {Program Name} > Program Image Upload". It defines a generic
BreadcrumbFactory
class that can create breadcrumbs for any content. Right now,ProgramImageView
is the only class usingBreadcrumbFactory
but I expectBreadcrumbFactory
will be used by other pages in the future.Here is the Figma with the breadcrumbs design.
Release notes
Checklist
General
Read the full guidelines for PRs here
civiform/developers
, or a more specific round-robin list.User visible changes
New Features
Instructions for manual testing
Issue(s) this completes
Epic #5676
Sub-task #5999